fix: cache default location safely - #37
Open
pragnyanramtha wants to merge 3 commits into
Open
Conversation
|
@pragnyanramtha is attempting to deploy a commit to the rohanhake256's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #33 by replacing the previous mutable module-level IP location cache in backend/routers/medicines.py with a single-entry functools.lru_cache, while keeping the fallback default location retryable after failures. It also adds backend unit tests to validate caching and fallback behavior.
Changes:
- Removed mutable global IP location cache state and introduced
DEFAULT_LOCATIONplus an@lru_cache(maxsize=1)-backed_fetch_ip_location(). - Updated
get_default_location()to return cached IP-based coordinates on success and fall back toDEFAULT_LOCATIONon failure. - Added unit tests covering (1) caching success and (2) retry behavior after an initial failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| backend/routers/medicines.py | Replaces mutable globals with an lru_cache-based IP lookup and a named default fallback. |
| backend/tests/test_medicines.py | Adds unit tests to assert caching behavior and failure fallback/retry behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lru_cacheFixes #33
Validation
python3 -m unittest discover backend/tests -vpython3 -m py_compile backend/routers/medicines.py backend/tests/test_medicines.pygit diff --check